[Spice-devel] [PATCH spice-gtk] Fix setting appsrc properties in i686 arch

[Frediano Ziglio]

> > > > The "max-bytes" property of the appsrc GStreamer element expects a
> > > 
> > 
> 
> > > > 64-bit value. Calling:
> > > 
> > 
> 
> > > > g_object_set(source, "max-bytes", 0, NULL);
> > > 
> > 
> 
> > > > in a 32-bit architecture ends up with a wrong value, it must be cast to
> > > 
> > 
> 
> > > > a long long int:
> > > 
> > 
> 
> > > > g_object_set(source, "max-bytes", 0LL, NULL);
> > > 
> > 
> 
> > > > ---
> > > 
> > 
> 
> > > > src/channel-display-gst.c | 2 +-
> > > 
> > 
> 
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > 
> 

> > > > diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
> > > 
> > 
> 
> > > > index f978602..c872a1f 100644
> > > 
> > 
> 
> > > > --- a/src/channel-display-gst.c
> > > 
> > 
> 
> > > > +++ b/src/channel-display-gst.c
> > > 
> > 
> 
> > > > @@ -333,7 +333,7 @@ static void app_source_setup(GstElement *pipeline
> > > 
> > 
> 
> > > > G_GNUC_UNUSED,
> > > 
> > 
> 
> > > > "caps", caps,
> > > 
> > 
> 
> > > > "is-live", TRUE,
> > > 
> > 
> 
> > > > "format", GST_FORMAT_TIME,
> > > 
> > 
> 
> > > > -                 "max-bytes", 0,
> > > 
> > 
> 
> > > > +                 "max-bytes", 0LL,
> > > 
> > 
> 
> > > > "block", TRUE,
> > > 
> > 
> 
> > > > NULL);
> > > 
> > 
> 
> > > > gst_caps_unref(caps);
> > > 
> > 
> 
> > > I would use a gint64 cast instead.
> > 
> 
> > > Beside that patch is fine.
> > 
> 
> > Or even better G_GINT64_CONSTANT(0).
> 

> Sure, didn't know about this macro. Do you want me to resend the modified
> patch?

> Javier

I was going to update the patch but I realized that the commit message is really bound 
to "long long"syntax. Can you send an updated patch? 

Frediano 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180130/b42cc0e0/attachment.html>