[Spice-devel] [PATCH spice-protocol] qxl_dev: Align QXLRam to 4 bytes

[Christophe Fergeau]

On Tue, Jul 03, 2018 at 11:38:56AM -0400, Frediano Ziglio wrote:
> > 
> > On Thu, Jun 28, 2018 at 09:43:47PM +0100, Frediano Ziglio wrote:
> > > This avoids compilers detect misaligned access.
> > 
> > Maybe "This helps some compilers to realize QXLRam is correctly aligned"?
> > 
> 
> Well, the current code tells the compiler that this structure
> is NOT aligned.
> But we actually know the opposite

Well, we know that in QEMU and Xspice, this is correctly aligned (but
one need to look at how ram offset is computed in order to see that), so
we add the annotation to spice-protocol. Since this is quite odd, the
commit log would indeed need to be quite descriptive.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180704/a1ee4d76/attachment.sig>