[Spice-devel] [PATCH spice-protocol] qxl_dev: Align QXLRam to 4 bytes

[Frediano Ziglio]

> 
> On Tue, Jul 03, 2018 at 11:38:56AM -0400, Frediano Ziglio wrote:
> > > 
> > > On Thu, Jun 28, 2018 at 09:43:47PM +0100, Frediano Ziglio wrote:
> > > > This avoids compilers detect misaligned access.
> > > 
> > > Maybe "This helps some compilers to realize QXLRam is correctly aligned"?
> > > 
> > 
> > Well, the current code tells the compiler that this structure
> > is NOT aligned.
> > But we actually know the opposite
> 
> Well, we know that in QEMU and Xspice, this is correctly aligned (but
> one need to look at how ram offset is computed in order to see that), so
> we add the annotation to spice-protocol. Since this is quite odd, the
> commit log would indeed need to be quite descriptive.
> 
> Christophe
> 

Suggestions?

Frediano