[Spice-devel] [PATCH qxl-wddm-dod] Do not set self_bitmap flag for QXL_DRAW_COPY command

Frediano Ziglio fziglio at redhat.com
Mon Jun 25 08:53:57 UTC 2018


Setting this flag on this command cause some performance issue.
When the server see this flag it updates the frame buffer and copy
part of it in a new allocated image. However for this command the
image is not used wasting only CPU and memory.
Also the frame buffer update causes the elimination optimisation
to be less effective causing more network usage.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 qxldod/QxlDod.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
index f74f54e..b72e12c 100755
--- a/qxldod/QxlDod.cpp
+++ b/qxldod/QxlDod.cpp
@@ -4607,9 +4607,6 @@ QXLDrawable *QxlDevice::PrepareBltBits (
     drawable->surfaces_dest[0] = 0;
     CopyRect(&drawable->surfaces_rects[0], pRect);
 
-    drawable->self_bitmap = TRUE;
-    CopyRect(&drawable->self_bitmap_area, pRect);
-
     height = pRect->bottom - pRect->top;
     width = pRect->right - pRect->left;
 
-- 
2.17.1



More information about the Spice-devel mailing list