[Spice-devel] [PATCH qxl-wddm-dod] Do not set self_bitmap flag for QXL_DRAW_COPY command

[Yuri Benditovich]

 Acked-by: Yuri Benditovich <yuri.benditovich at daynix.com
<cfergeau at redhat.com>>

On Mon, Jun 25, 2018 at 11:53 AM, Frediano Ziglio <fziglio at redhat.com>
wrote:

> Setting this flag on this command cause some performance issue.
> When the server see this flag it updates the frame buffer and copy
> part of it in a new allocated image. However for this command the
> image is not used wasting only CPU and memory.
> Also the frame buffer update causes the elimination optimisation
> to be less effective causing more network usage.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  qxldod/QxlDod.cpp | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> index f74f54e..b72e12c 100755
> --- a/qxldod/QxlDod.cpp
> +++ b/qxldod/QxlDod.cpp
> @@ -4607,9 +4607,6 @@ QXLDrawable *QxlDevice::PrepareBltBits (
>      drawable->surfaces_dest[0] = 0;
>      CopyRect(&drawable->surfaces_rects[0], pRect);
>
> -    drawable->self_bitmap = TRUE;
> -    CopyRect(&drawable->self_bitmap_area, pRect);
> -
>      height = pRect->bottom - pRect->top;
>      width = pRect->right - pRect->left;
>
> --
> 2.17.1
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180626/d883c188/attachment.html>