[Spice-devel] [PATCH spice-streaming-agent v2 1/1] rename the virtio port to org.spice-space.stream.0

Lukáš Hrázký lhrazky at redhat.com
Fri Mar 23 14:57:54 UTC 2018


The name 'com.redhat.stream.0' is too generic and in no way denotes it
belongs to SPICE. It is preferred to have the project's domain in the
name and Red Hat doesn't own the project. Rename it to
org.spice-space.stream.0.

Signed-off-by: Lukáš Hrázký <lhrazky at redhat.com>
---
 README                              | 12 ++++++------
 data/90-spice-guest-streaming.rules |  2 +-
 src/spice-streaming-agent.cpp       |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/README b/README
index 7e9a3c7..544c54c 100644
--- a/README
+++ b/README
@@ -13,7 +13,7 @@ Virtual Machine Configuration
 =============================
 
 In order to set up streaming, qemu needs to expose a
-`com.redhat.stream.0` virtio port, associated with a
+`org.spice-space.stream.0` virtio port, associated with a
 corresponding Spice port.
 
 Using virt-manager
@@ -21,8 +21,8 @@ Using virt-manager
 
 In the hardware details, click on "Add Hardware", then select
 "Channel". Add a "Spice port" device type with the
-"com.redhat.stream.0" name. You also need to set "Channel" to
-"com.redhat.stream.0"
+"org.spice-space.stream.0" name. You also need to set "Channel" to
+"org.spice-space.stream.0"
 
 
 Using libvirt
@@ -31,8 +31,8 @@ Using libvirt
 [source,xml]
 <devices>
     <channel type='spiceport'>
-        <source channel='com.redhat.stream.0'/>
-        <target type='virtio' name='com.redhat.stream.0'/>
+        <source channel='org.spice-space.stream.0'/>
+        <target type='virtio' name='org.spice-space.stream.0'/>
     </channel>
 </devices>
 
@@ -40,4 +40,4 @@ Using QEMU
 ----------
 
 [source,sh]
--device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel1,id=channel1,name=com.redhat.stream.0 -chardev spiceport,name=com.redhat.stream.0,id=charchannel1
+-device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel1,id=channel1,name=org.spice-space.stream.0 -chardev spiceport,name=org.spice-space.stream.0,id=charchannel1
diff --git a/data/90-spice-guest-streaming.rules b/data/90-spice-guest-streaming.rules
index 6cedd5c..f143c77 100644
--- a/data/90-spice-guest-streaming.rules
+++ b/data/90-spice-guest-streaming.rules
@@ -1,2 +1,2 @@
-ACTION=="add", SUBSYSTEM=="virtio-ports", ENV{DEVLINKS}=="/dev/virtio-ports/com.redhat.stream.0", MODE="0666"
+ACTION=="add", SUBSYSTEM=="virtio-ports", ENV{DEVLINKS}=="/dev/virtio-ports/org.spice-space.stream.0", MODE="0666"
 
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index b39782c..8b3f833 100644
--- a/src/spice-streaming-agent.cpp
+++ b/src/spice-streaming-agent.cpp
@@ -480,7 +480,7 @@ done:
 
 int main(int argc, char* argv[])
 {
-    const char *streamport = "/dev/virtio-ports/com.redhat.stream.0";
+    const char *streamport = "/dev/virtio-ports/org.spice-space.stream.0";
     int opt;
     const char *log_filename = NULL;
     int logmask = LOG_UPTO(LOG_WARNING);
-- 
2.16.2



More information about the Spice-devel mailing list