[Spice-devel] [PATCH spice v2 1/1] rename the virtio port for streaming

[Victor Toso]

Hi,

On Fri, Mar 23, 2018 at 04:40:28PM +0100, Christophe de Dinechin wrote:
> 
> 
> > On 23 Mar 2018, at 15:57, Lukáš Hrázký <lhrazky at redhat.com> wrote:
> > 
> > From: Lukáš Hrázký <lukkash at email.cz>
> > 
> > The name 'com.redhat.stream.0' is too generic and in no way denotes it
> > belongs to SPICE. It is preferred to have the project's domain in the
> > name and Red Hat doesn't own the project. Rename it to
> > org.spice-space.stream.0.
> > 
> > Signed-off-by: Lukáš Hrázký <lukkash at email.cz>
> > ---
> > server/reds.c                     | 2 +-
> > server/tests/test-stream-device.c | 2 +-
> > spice-common                      | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/server/reds.c b/server/reds.c
> > index 998f2ffa..935448d8 100644
> > --- a/server/reds.c
> > +++ b/server/reds.c
> > @@ -3145,7 +3145,7 @@ static int spice_server_char_device_add_interface(SpiceServer *reds,
> >     else if (strcmp(char_device->subtype, SUBTYPE_PORT) == 0) {
> >         if (strcmp(char_device->portname, "org.spice-space.webdav.0") == 0) {
> >             dev_state = spicevmc_device_connect(reds, char_device, SPICE_CHANNEL_WEBDAV);
> > -        } else if (strcmp(char_device->portname, "com.redhat.stream.0") == 0) {
> > +        } else if (strcmp(char_device->portname, "org.spice-space.stream.0") == 0) {
> 
> In addition to Frediano’s remarks, I would probably accept the
> two names during some transition period.

There were 0 releases in spice server with this. If this only
affect developers, I would prefer to keep it simple with only the
new name allowed.


> Otherwise, we are going to make everybody outside of our team
> miserable (and inside too, while we juggle configurations
> around this patch).

The warning in the log should be a good hint that this has
changed!

    toso

> 
> >             dev_state = RED_CHAR_DEVICE(stream_device_connect(reds, char_device));
> >         } else {
> >             dev_state = spicevmc_device_connect(reds, char_device, SPICE_CHANNEL_PORT);
> > diff --git a/server/tests/test-stream-device.c b/server/tests/test-stream-device.c
> > index 3c9209a4..2fdd0a39 100644
> > --- a/server/tests/test-stream-device.c
> > +++ b/server/tests/test-stream-device.c
> > @@ -107,7 +107,7 @@ static SpiceCharDeviceInterface vmc_interface = {
> > // this specifically creates a stream device
> > static SpiceCharDeviceInstance vmc_instance = {
> >     .subtype = "port",
> > -    .portname = "com.redhat.stream.0",
> > +    .portname = "org.spice-space.stream.0",
> > };
> > 
> > static uint8_t *add_stream_hdr(uint8_t *p, StreamMsgType type, uint32_t size)
> > diff --git a/spice-common b/spice-common
> > index 4c2d0e97..45e28448 160000
> > --- a/spice-common
> > +++ b/spice-common
> > @@ -1 +1 @@
> > -Subproject commit 4c2d0e977272c5540634d24f485dd64c424f6748
> > +Subproject commit 45e2844845242b32b2bd8956da0dfffa91c0d856
> > -- 
> > 2.16.2
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180329/715703b4/attachment-0001.sig>