[Spice-devel] [spice-gtk] widget: update comment on fixed gtk+ bug

Victor Toso victortoso at redhat.com
Mon May 21 12:20:14 UTC 2018


From: Victor Toso <me at victortoso.com>

The bug was fixed in GTK+ 3.22. I'm updating the comment plus setting
the !GTK_CHECK_VERSION() to track changes that can be removed after
bumping the gtk+ library.

Signed-off-by: Victor Toso <victortoso at redhat.com>
---
 src/spice-widget.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/spice-widget.c b/src/spice-widget.c
index 767550b..72f5334 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -1623,9 +1623,9 @@ G_GNUC_END_IGNORE_DEPRECATIONS
         return true;
 
     if (key->keyval == GDK_KEY_Pause
-#ifdef G_OS_WIN32
-        /* for some reason GDK does not fill keyval for VK_PAUSE
-         * See https://bugzilla.gnome.org/show_bug.cgi?id=769214
+#if defined(G_OS_WIN32) && !GTK_CHECK_VERSION(3, 22, 0)
+        /* Bug https://bugzilla.gnome.org/show_bug.cgi?id=769214
+         * Fixed in 3.22 with 125ef35
          */
         || key->hardware_keycode == VK_PAUSE
 #endif
-- 
2.17.0



More information about the Spice-devel mailing list