[Spice-devel] [spice-gtk] widget: update comment on fixed gtk+ bug

[Christophe Fergeau]

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Mon, May 21, 2018 at 02:20:14PM +0200, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> The bug was fixed in GTK+ 3.22. I'm updating the comment plus setting
> the !GTK_CHECK_VERSION() to track changes that can be removed after
> bumping the gtk+ library.
> 
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  src/spice-widget.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index 767550b..72f5334 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -1623,9 +1623,9 @@ G_GNUC_END_IGNORE_DEPRECATIONS
>          return true;
>  
>      if (key->keyval == GDK_KEY_Pause
> -#ifdef G_OS_WIN32
> -        /* for some reason GDK does not fill keyval for VK_PAUSE
> -         * See https://bugzilla.gnome.org/show_bug.cgi?id=769214
> +#if defined(G_OS_WIN32) && !GTK_CHECK_VERSION(3, 22, 0)
> +        /* Bug https://bugzilla.gnome.org/show_bug.cgi?id=769214
> +         * Fixed in 3.22 with 125ef35
>           */
>          || key->hardware_keycode == VK_PAUSE
>  #endif
> -- 
> 2.17.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180522/12a5eee4/attachment.sig>