[Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

[Christophe Fergeau]

On Wed, Apr 25, 2018 at 04:26:40AM -0400, Frediano Ziglio wrote:
> > > > On Fri, Apr 06, 2018 at 09:59:43AM +0200, Victor Toso wrote:
> > > > > From: Victor Toso <me at victortoso.com>
> > > > > 
> > > > > This reverts commit 291f3e4419e6fb4077ae43a5e09eb1c37b9dd729
> > > > > 
> > > > > Follow up patch should address rhbz#1399838 mentioned in commit above
> > > > > in a different way.
> > > > > 
> > > > > Major reason to revert is that the SpiceUsbDeviceManager object is
> > > > > kept in SpiceSession as an easy way to share it between different
> > > > > SpiceUsbredirChannel while SpiceSession itself does not use it. This
> > > > > causes problems on migration as we start a new session with a new
> > > > > SpiceUsbDeviceManager object while the previous one still exists.
> > > > > 
> 
> Maybe SpiceUsbDeviceManager should be a global (singleton) meaning that you
> should not create a new object but just add a reference to it even from
> another SpiceSession?

For what it's worth, this used to be a singleton, and was changed in
https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=971eb9be73ee306e7e5c1a0d07251fd01f967d1d

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180530/8c9c9a8a/attachment.sig>