[Spice-devel] [PATCH spice-common] proto: Fix typo in message name

Victor Toso victortoso at redhat.com
Wed Apr 3 08:16:04 UTC 2019


Hi,

On Tue, Apr 02, 2019 at 02:46:33PM +0100, Frediano Ziglio wrote:
> RecoderChannel::data message is the same as PlaybackChannel::data
> one.

Is this the right fix? What I see here is that in the
RecordChannel you changed SpiceMsgcRecordPacket to
SpiceMsgcPlaybackPacket which already exists in PlaybackChannel

    https://gitlab.freedesktop.org/spice/spice-common/commit/bd75d3f9#8bec748edb53e9a6236c03fc4fdfe83966a4ac14_1225_1225

Cheers,

> This fixed compilation of spice-gtk using updated spice-common.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  spice.proto | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/spice.proto b/spice.proto
> index 1f9f57b..3bbec0c 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -1222,7 +1222,7 @@ channel RecordChannel : BaseChannel {
>      message {
>          uint32 time;
>          uint8 data[] @nomarshal @as_ptr(data_size);
> -    } @ctype(SpiceMsgcPlaybackPacket) @declare data = 101;
> +    } @ctype(SpiceMsgPlaybackPacket) @declare data = 101;
>  
>      message {
>          uint32 time;
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190403/275b1cca/attachment.sig>


More information about the Spice-devel mailing list