[Spice-devel] [PATCH spice-common v2] proto: Fix typo in message name

Frediano Ziglio fziglio at redhat.com
Wed Apr 3 08:53:21 UTC 2019


RecoderChannel::data message is the same as PlaybackChannel::data
one.
This fixed compilation of spice-gtk using updated spice-common.

Before generating the messages automatically the definition was:

  typedef struct SpiceMsgPlaybackPacket {
      uint32_t time;
      uint8_t *data;
      uint32_t data_size;
  } SpiceMsgPlaybackPacket, SpiceMsgcRecordPacket;

so both messages were defined as struct SpiceMsgPlaybackPacket with
SpiceMsgcRecordPacket an alias to it.

But spice.proto for RecordChannel::data was changed from
SpiceMsgcRecordPacket (the alias) to SpiceMsgcPlaybackPacket
defining a new structure and breaking the alias.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 spice.proto | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Changes since v1:
- commit message with more explanations.

diff --git a/spice.proto b/spice.proto
index 1f9f57b..3bbec0c 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1222,7 +1222,7 @@ channel RecordChannel : BaseChannel {
     message {
         uint32 time;
         uint8 data[] @nomarshal @as_ptr(data_size);
-    } @ctype(SpiceMsgcPlaybackPacket) @declare data = 101;
+    } @ctype(SpiceMsgPlaybackPacket) @declare data = 101;
 
     message {
         uint32 time;
-- 
2.20.1



More information about the Spice-devel mailing list