[Spice-devel] [PATCH spice-common v2] proto: Fix typo in message name

[Victor Toso]

Hi,

On Wed, Apr 03, 2019 at 09:53:21AM +0100, Frediano Ziglio wrote:
> RecoderChannel::data message is the same as PlaybackChannel::data
> one.
> This fixed compilation of spice-gtk using updated spice-common.
> 
> Before generating the messages automatically the definition was:
> 
>   typedef struct SpiceMsgPlaybackPacket {
>       uint32_t time;
>       uint8_t *data;
>       uint32_t data_size;
>   } SpiceMsgPlaybackPacket, SpiceMsgcRecordPacket;
> 
> so both messages were defined as struct SpiceMsgPlaybackPacket with
> SpiceMsgcRecordPacket an alias to it.
> 
> But spice.proto for RecordChannel::data was changed from
> SpiceMsgcRecordPacket (the alias) to SpiceMsgcPlaybackPacket
> defining a new structure and breaking the alias.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

Thanks for the clarification,
Acked-by: Victor Toso <victortoso at redhat.com>

> ---
>  spice.proto | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Changes since v1:
> - commit message with more explanations.
> 
> diff --git a/spice.proto b/spice.proto
> index 1f9f57b..3bbec0c 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -1222,7 +1222,7 @@ channel RecordChannel : BaseChannel {
>      message {
>          uint32 time;
>          uint8 data[] @nomarshal @as_ptr(data_size);
> -    } @ctype(SpiceMsgcPlaybackPacket) @declare data = 101;
> +    } @ctype(SpiceMsgPlaybackPacket) @declare data = 101;
>  
>      message {
>          uint32 time;
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190403/bf40332e/attachment.sig>