[Spice-devel] [PATCH spice-html5] Make the audio and video uids different.

Frediano Ziglio fziglio at redhat.com
Sun Aug 11 09:34:27 UTC 2019


Hi,
  I saw no updated since the review.
Is this patch still useful?

Frediano

> 
> Hi,
> 
> On Fri, 2016-12-23 at 10:53 -0600, Jeremy White wrote:
> > This does not appear to matter, but let's just be safe.
> > 
> sure
> 
> 
> > Signed-off-by: Jeremy White <jwhite at codeweavers.com>
> > ---
> >  webm.js | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/webm.js b/webm.js
> > index 72c1853..6245498 100644
> > --- a/webm.js
> > +++ b/webm.js
> > @@ -406,7 +406,7 @@ function webm_AudioTrackEntry()
> >      */
> >      this.id = WEBM_TRACK_ENTRY;
> >      this.number = 1;
> > -    this.uid = 1;
> > +    this.uid = 2;
> 
> What about using some variable instead of number (like
> WEBM_AUDIO_UID)?
> 
> Pavel
> 
> >      this.type = 2; // Audio
> >      this.flag_enabled = 1;
> >      this.flag_default = 1;


More information about the Spice-devel mailing list