[Spice-devel] [spice-server PATCH 1/3] compress_seg: comment out unused assignment

Uri Lublin uril at redhat.com
Sun Aug 11 11:47:21 UTC 2019


CLANG warning: "Value stored to 'ref_limit' is never read"

Commenting out since there is a ToDo that refers to ref_limit

Found by Covscan.

Signed-off-by: Uri Lublin <uril at redhat.com>
---

Should the comment be deleted too ?

---
 server/glz-encode.tmpl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/glz-encode.tmpl.c b/server/glz-encode.tmpl.c
index 48bab50bc..ad48c86c8 100644
--- a/server/glz-encode.tmpl.c
+++ b/server/glz-encode.tmpl.c
@@ -282,7 +282,7 @@ static void FNAME(compress_seg)(Encoder *encoder, uint32_t seg_idx, PIXEL *from,
 
                 ip += 3;
                 ref = anchor + 2;
-                ref_limit = (PIXEL *)(seg->lines_end);
+                //ref_limit = (PIXEL *)(seg->lines_end);
                 len = 3;
 
                 x = *ref;
-- 
2.21.0



More information about the Spice-devel mailing list