[Spice-devel] [PATCH spice-protocol] qxl_dev: Add comment to QXLQUICData->data field

Frediano Ziglio fziglio at redhat.com
Tue Aug 13 09:50:32 UTC 2019


Recently a bug using this structure was fixed.
The bug involved understand the usage of this field so add some
note on the field for future reference.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 spice/qxl_dev.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h
index c844d7b..3f56aae 100644
--- a/spice/qxl_dev.h
+++ b/spice/qxl_dev.h
@@ -740,6 +740,9 @@ typedef struct SPICE_ATTR_PACKED QXLSurfaceId {
 
 typedef struct SPICE_ATTR_PACKED QXLQUICData {
     uint32_t data_size;
+    /* This data for QUIC is a QXLDataChunk.
+     * This differs from QXLBitmap where it's a reference to bitmap data or
+     * a reference to QXLDataChunk */
     uint8_t data[0];
 } QXLQUICData, QXLLZRGBData, QXLJPEGData;
 
-- 
2.20.1



More information about the Spice-devel mailing list