[Spice-devel] [PATCH] drm/qxl: remove unnecessary BUG_ON check for handle

Aditya Pakki pakki001 at umn.edu
Thu Dec 5 23:42:31 UTC 2019


In qxl_gem_object_create_with_handle(), handle's memory is not
allocated on the heap. Checking for failure of handle via BUG_ON
is unnecessary. This patch eliminates the check.

Signed-off-by: Aditya Pakki <pakki001 at umn.edu>
---
 drivers/gpu/drm/qxl/qxl_gem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/qxl/qxl_gem.c b/drivers/gpu/drm/qxl/qxl_gem.c
index 69f37db1027a..45b779a8bc22 100644
--- a/drivers/gpu/drm/qxl/qxl_gem.c
+++ b/drivers/gpu/drm/qxl/qxl_gem.c
@@ -84,7 +84,6 @@ int qxl_gem_object_create_with_handle(struct qxl_device *qdev,
 	int r;
 
 	BUG_ON(!qobj);
-	BUG_ON(!handle);
 
 	r = qxl_gem_object_create(qdev, size, 0,
 				  domain,
-- 
2.17.1



More information about the Spice-devel mailing list