[Spice-devel] [PATCH 9/9] remove un-connected shared CD devices upon usb-device-widget construction

[Alexander Nezhinsky]

On Fri, Dec 6, 2019 at 12:32 PM Frediano Ziglio <fziglio at redhat.com> wrote:

> >
> > From: Alexander Nezhinsky <anezhins at redhat.com>
> >
> > Some corner error scenarios may leave dangling not connected shared CD
> > devices.
> > As the current flow precludes maintenance of such devices, it may be
> prudent
> > to identify and remove them.
> >
> > Signed-off-by: Alexander Nezhinsky <anezhins at redhat.com>
>
> This patch and code seems to indicate a workaround for a bug in
> the implementation.
>
It is not about *a bug*. It is a host of corner cases where the CD remained
connected and unremoved.
This is not a concern with the "real" devices, as they can be present on
the system and become unconnected.
It could be the same case for a shared CD if we'd have supported such a
state.
But we decided to disallow it - if the connection is lost, the Cd devices
should be gone.
This creates a potentially problematic state.
Instead of hunting after all such cases and in some cases finding it
difficult to cope with them, it seems to be reasonable to solve it this
way.
We may decide otherwise, but I'd suggest that even then we accept the
patch, leave it as a known issue and dedicate a few separate patches to the
fix, perhaps immediately.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20191206/8ee1e838/attachment-0001.html>