[Spice-devel] [PATCH 3/9] Add --spice-share-cd command line option

[Alexander Nezhinsky]

On Fri, Dec 6, 2019 at 12:06 PM Frediano Ziglio <fziglio at redhat.com> wrote:

> >
> > From: Alexander Nezhinsky <anezhins at redhat.com>
> > +                rc = spice_usb_device_manager_create_shared_cd_device(m,
> > *name, &err);
> > +                if (!rc) {
> > +                    if (!err)
>
> minor: err == NULL
>
OK


>
> > +                        g_warning("Failed to create shared CD device
> %s",
> > +                    else
> > +                        g_warning("Failed to create shared CD device %s:
>
> style: always brackets
>
Sure


>
> as you check for err above you can include in the else.
>
OK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20191206/c21a9b70/attachment.html>