[Spice-devel] [PATCH spice-gtk 03/12] meson: fix po generation

[Frediano Ziglio]

> Hi
> On Tue, Feb 12, 2019 at 12:35 PM Frediano Ziglio <fziglio at redhat.com> wrote:
> >
> >
> > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > >
> > > Use glib preset (from meson v0.37) to catch all our translatable
> > > strings and use good default settings.
> > >

Comparing with Autoconf they catch a bit less strings,
I'll send them a patch.

There are also some differences like
  --copyright-holder=Copyright (C) 2010-2017 Red Hat, Inc.
  --package-version=0.36.33-8990-dirty
  --msgid-bugs-address=spice-devel at lists.freedesktop.org
First 2 seems to have no difference, third do not fill the
"Report-Msgid-Bugs-To" entry in the .po files.

> > > While at it, remove the needless directory argument.
> > >
> > > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > With or without this patch Meson seems to do nothing in the po/
> > directory, .gmo files are not generated.
> > I cannot see any warning in Meson output about i18n.
> >
> 
> For some reasons, meson doesn't build everything at build time by
> default, some things are delayed at install time (such as doc).
> 
> Try:
> ninja meson-spice-gtk-gmo
> 

In this case better

ninja meson-spice-gtk-update-po

> >
> > > ---
> > >  po/meson.build | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/po/meson.build b/po/meson.build
> > > index 60c27a7..fb3c395 100644
> > > --- a/po/meson.build
> > > +++ b/po/meson.build
> > > @@ -1,3 +1,3 @@
> > >  i18n = import('i18n')
> > >  i18n.gettext(meson.project_name(),
> > > -             args : '--directory=@0@'.format(meson.source_root()))
> > > +             preset : 'glib')

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano