[Spice-devel] [linux/vd-agent 3/3] README: Use block quotes for code or paths

[Victor Toso]

On Sat, Feb 23, 2019 at 03:49:47PM +0100, Jakub Janku wrote:
> Hi,
> 
> in the README file, there are some formatting errors that I think
> could be fixed in this patch as well, namely:
> 
> * Sentence starting with "Then connect" should be in a new paragraph,
> not in the nested list

Sure


> * the command "spicec --full-screen=auto-config" could be enclosed in
> backquotes rather than doubleqoutes

Should be removed actually, I've never ran spicec myself. Old
stuff.

> * the sublist containing limitations of multi-monitor setup is not
> properly formatted

Correct, I'll see what to remove and what to fix and resend.

Thanks ;)

> 
> Cheers,
> Jakub
> 
> On Fri, Feb 22, 2019 at 4:19 PM Victor Toso <victortoso at redhat.com> wrote:
> >
> > From: Victor Toso <me at victortoso.com>
> >
> > Makes it easier to copy-and-paste.
> >
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  README.md | 17 +++++++++++------
> >  1 file changed, 11 insertions(+), 6 deletions(-)
> >
> > diff --git a/README.md b/README.md
> > index 67a66a5..089c0e5 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -44,15 +44,20 @@ All vdagent communications on the guest side run over a single pipe which
> >  gets presented to the guest os as a virtio serial port.
> >
> >  Under windows this virtio serial port has the following name:
> > -\\\\.\\Global\\com.redhat.spice.0
> > +>>>
> > +    \\\\.\\Global\\com.redhat.spice.0
> > +>>>
> >
> >  Under Linux this virtio serial port has the following name:
> > -/dev/virtio-ports/com.redhat.spice.0
> > +>>>
> > +    /dev/virtio-ports/com.redhat.spice.0
> > +>>>
> >
> >  To enable the virtio serial port you need to pass the following params on
> >  the qemu cmdline:
> >
> > --device virtio-serial-pci,id=virtio-serial0,max_ports=16,bus=pci.0,addr=0x5 \
> > --chardev spicevmc,name=vdagent,id=vdagent \
> > --device \
> > -virtserialport,nr=1,bus=virtio-serial0.0,chardev=vdagent,name=com.redhat.spice.0
> > +>>>
> > +    -device virtio-serial-pci,id=virtio-serial0,max_ports=16,bus=pci.0,addr=0x5 \
> > +    -chardev spicevmc,name=vdagent,id=vdagent \
> > +    -device virtserialport,nr=1,bus=virtio-serial0.0,chardev=vdagent,name=com.redhat.spice.0
> > +>>>
> > --
> > 2.20.1
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190225/128364c4/attachment.sig>