[Spice-devel] [PATCH spice-server] display-channel: Remove unused includes

Christophe Fergeau cfergeau at redhat.com
Wed Jan 30 12:53:05 UTC 2019


On Wed, Jan 30, 2019 at 09:46:34AM +0000, Frediano Ziglio wrote:
> display-channel.h is not using any of the definition from
> these headers.
> 

I'd mention the red-worker.c change, looks good otherwise

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/display-channel.h | 10 ----------
>  server/red-worker.c      |  1 +
>  2 files changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/server/display-channel.h b/server/display-channel.h
> index 5fcf7035..948018cf 100644
> --- a/server/display-channel.h
> +++ b/server/display-channel.h
> @@ -22,21 +22,11 @@
>  #include <setjmp.h>
>  #include <common/rect.h>
>  
> -#include "red-stream.h"
> -#include "cache-item.h"
> -#include "pixmap-cache.h"
> -#include "stat.h"
>  #include "reds.h"
> -#include "memslot.h"
>  #include "red-parse-qxl.h"
> -#include "red-record-qxl.h"
>  #include "red-channel.h"
> -#include "dispatcher.h"
>  #include "main-channel.h"
> -#include "migration-protocol.h"
> -#include "main-dispatcher.h"
>  #include "spice-bitmap-utils.h"
> -#include "utils.h"
>  #include "tree.h"
>  #include "video-stream.h"
>  #include "dcc.h"
> diff --git a/server/red-worker.c b/server/red-worker.c
> index f016943a..c74ae888 100644
> --- a/server/red-worker.c
> +++ b/server/red-worker.c
> @@ -45,6 +45,7 @@
>  #include "red-qxl.h"
>  #include "cursor-channel.h"
>  #include "tree.h"
> +#include "red-record-qxl.h"
>  
>  // compatibility for FreeBSD
>  #ifdef HAVE_PTHREAD_NP_H
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190130/da3040f0/attachment.sig>


More information about the Spice-devel mailing list