[Spice-devel] [PATCH spice-server] display-channel: Remove unused includes

[Frediano Ziglio]

----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: "Frediano Ziglio" <fziglio at redhat.com>
> Cc: spice-devel at lists.freedesktop.org
> Sent: Wednesday, 30 January, 2019 12:53:05 PM
> Subject: Re: [Spice-devel] [PATCH spice-server] display-channel: Remove unused includes
> 
> On Wed, Jan 30, 2019 at 09:46:34AM +0000, Frediano Ziglio wrote:
> > display-channel.h is not using any of the definition from
> > these headers.
> > 
> 
> I'd mention the red-worker.c change, looks good otherwise

Like

"Adding a missing include to red-worker.c." ?

> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/display-channel.h | 10 ----------
> >  server/red-worker.c      |  1 +
> >  2 files changed, 1 insertion(+), 10 deletions(-)
> > 
> > diff --git a/server/display-channel.h b/server/display-channel.h
> > index 5fcf7035..948018cf 100644
> > --- a/server/display-channel.h
> > +++ b/server/display-channel.h
> > @@ -22,21 +22,11 @@
> >  #include <setjmp.h>
> >  #include <common/rect.h>
> >  
> > -#include "red-stream.h"
> > -#include "cache-item.h"
> > -#include "pixmap-cache.h"
> > -#include "stat.h"
> >  #include "reds.h"
> > -#include "memslot.h"
> >  #include "red-parse-qxl.h"
> > -#include "red-record-qxl.h"
> >  #include "red-channel.h"
> > -#include "dispatcher.h"
> >  #include "main-channel.h"
> > -#include "migration-protocol.h"
> > -#include "main-dispatcher.h"
> >  #include "spice-bitmap-utils.h"
> > -#include "utils.h"
> >  #include "tree.h"
> >  #include "video-stream.h"
> >  #include "dcc.h"
> > diff --git a/server/red-worker.c b/server/red-worker.c
> > index f016943a..c74ae888 100644
> > --- a/server/red-worker.c
> > +++ b/server/red-worker.c
> > @@ -45,6 +45,7 @@
> >  #include "red-qxl.h"
> >  #include "cursor-channel.h"
> >  #include "tree.h"
> > +#include "red-record-qxl.h"
> >  
> >  // compatibility for FreeBSD
> >  #ifdef HAVE_PTHREAD_NP_H