[Spice-devel] [PATCH phodav 1/2] spice: read_thread: return number of read bytes on EOF

Jakub Janků jjanku at redhat.com
Mon Jul 22 13:22:10 UTC 2019


We already check with each input_stream_read_thread_finish()
whether the count of the read bytes matches the requested one.

Also, this is the way GLib handles it.

Signed-off-by: Jakub Janků <jjanku at redhat.com>
---

https://gitlab.gnome.org/GNOME/phodav/merge_requests/4

I've opened the merge request on gitlab some time ago,
so now I'm sending it here as a form of ping.

---
 spice/spice-webdavd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index f814890..81b4d91 100644
--- a/spice/spice-webdavd.c
+++ b/spice/spice-webdavd.c
@@ -180,10 +180,6 @@ read_thread (GTask *task,
       g_debug ("error: %s", error->message);
       g_task_return_error (task, error);
     }
-  if (bread != data->count)
-    {
-      g_task_return_int (task, -1);
-    }
   else
     {
       g_task_return_int (task, bread);
-- 
2.21.0



More information about the Spice-devel mailing list