[Spice-devel] [PATCH spice-gtk 1/2] spice-widget-egl: Use sizeof instead of hand coded constant

Snir Sheriber ssheribe at redhat.com
Mon Jul 22 13:20:57 UTC 2019


Acked-by: Snir Sheriber <ssheribe at redhat.com>

On 7/22/19 2:25 PM, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>   src/spice-widget-egl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> index 7bae4e58..7db66082 100644
> --- a/src/spice-widget-egl.c
> +++ b/src/spice-widget-egl.c
> @@ -129,7 +129,7 @@ static gboolean spice_egl_init_shaders(SpiceDisplay *display, GError **err)
>       glLinkProgram(d->egl.prog);
>       glGetProgramiv(d->egl.prog, GL_LINK_STATUS, &status);
>       if (!status) {
> -        glGetProgramInfoLog(d->egl.prog, 1000, &len, log);
> +        glGetProgramInfoLog(d->egl.prog, sizeof(log), &len, log);
>           g_set_error(err, SPICE_CLIENT_ERROR, SPICE_CLIENT_ERROR_FAILED,
>                       "error linking shaders: %s", log);
>           goto end;


More information about the Spice-devel mailing list