[Spice-devel] [PATCH spice-gtk 2/2] spice-widget-egl: Declare and initialise "tex" and "verts" shortly

[Victor Toso]

Hi,

On Mon, Jul 22, 2019 at 12:26:00PM +0100, Frediano Ziglio wrote:
> Just syntax change.
> Reduce code to initialise these matrices.

Yes, looks nicer.
Acked-by: Victor Toso <victortoso at redhat.com>

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  src/spice-widget-egl.c | 40 +++++++++++++---------------------------
>  1 file changed, 13 insertions(+), 27 deletions(-)
> 
> diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> index 7db66082..f5e24a01 100644
> --- a/src/spice-widget-egl.c
> +++ b/src/spice-widget-egl.c
> @@ -489,33 +489,19 @@ client_draw_rect_tex(SpiceDisplay *display,
>                       float x, float y, float w, float h,
>                       float tx, float ty, float tw, float th)
>  {
> -    float verts[4][4];
> -    float tex[4][2];
> -
> -    verts[0][0] = x;
> -    verts[0][1] = y;
> -    verts[0][2] = 0.0;
> -    verts[0][3] = 1.0;
> -    tex[0][0] = tx;
> -    tex[0][1] = ty;
> -    verts[1][0] = x + w;
> -    verts[1][1] = y;
> -    verts[1][2] = 0.0;
> -    verts[1][3] = 1.0;
> -    tex[1][0] = tx + tw;
> -    tex[1][1] = ty;
> -    verts[2][0] = x;
> -    verts[2][1] = y + h;
> -    verts[2][2] = 0.0;
> -    verts[2][3] = 1.0;
> -    tex[2][0] = tx;
> -    tex[2][1] = ty + th;
> -    verts[3][0] = x + w;
> -    verts[3][1] = y + h;
> -    verts[3][2] = 0.0;
> -    verts[3][3] = 1.0;
> -    tex[3][0] = tx + tw;
> -    tex[3][1] = ty + th;
> +    GLfloat tex[4][2] = {
> +        { tx, ty },
> +        { tx + tw, ty },
> +        { tx, ty + th },
> +        { tx + tw, ty + th },
> +    };
> +
> +    GLfloat verts[4][4] = {
> +        { x, y, 0.0, 1.0 },
> +        { x + w, y, 0.0, 1.0 },
> +        { x, y + h, 0.0, 1.0 },
> +        { x + w, y + h, 0.0, 1.0 },
> +    };
>  
>      draw_rect_from_arrays(display, verts, tex);
>  }
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190723/126916ee/attachment.sig>