[Spice-devel] [spice-gtk 12/13] usb-redir: use persistent libusb_device under Windows also

Yuri Benditovich yuri.benditovich at daynix.com
Wed Mar 13 08:38:09 UTC 2019


On Tue, Mar 12, 2019 at 7:31 PM Christophe Fergeau <cfergeau at redhat.com> wrote:
>
> On Sun, Mar 10, 2019 at 04:46:11PM +0200, Yuri Benditovich wrote:
> > Unify SpiceUsbDeviceInfo for Linux and Windows by using
> > persistent libusb_device.
>
> This really needs to be more detailed and explain why this is no longer
> a valid concern:
>
> * On win32 we need to do this the hard and slow way, by asking libusb to
> * re-enumerate all devices and then finding a matching device.
> * We cannot cache the libusb_device like we do under Linux since the
> * driver swap we do under windows invalidates the cached libdev.
>

Probably it was written years ago for 'libusb + winusb'; it is just
incorrect for 'libusb + usbdk'.



> Christophe
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCAAdFiEElKn3VmH3emFoZJsjqdjCFCmsbIIFAlyH7OoACgkQqdjCFCms
> bILYhw/+OTJADB5cSdo9SEqEc2k/RtxQUwl4JbqwRPKq4DcQD/ZrxEzEZv5ljqCe
> y1Sl3zglPCQsu8tJmaVFk2PtPmCtp9wbTmMT1IT8kdTCtIgYCCltIouZHlHLGjNz
> n5rZSn8hOZxPoshPd0oafIBkoP8eWzPI1Lt0CP+yaZMJ+7t9A60kzQHD64EgmQRf
> Ymnkjw7yFvdGwLaH872O8oy1HaPH3Uads5AHkzz0MSvM39lEACjdW1xyJ9pdExjL
> YG+8VBdJxbUEJsCF3zdG726is5xZHzqho1oWgFqU4GPGGepXGMSo3dAxLnczfDwf
> +AvVRS7HRMmoNYpN863vd0HQrWE1niFltyG5r0hdmZsQrMZtey0eoKfnTirYOXs+
> J9i8pKXkwLOF7NlNs6zH5SMxpQnicT0IaGXYXTvl1oR2xAxbKnZZummwSutf/gX1
> bhlxP26kyBekKw8/0PHpDFaIeSNeZBMEFySfL+ciK7SchJXZjDB+qrqWMkZmftdw
> I6fUY7OchAvYzkeiY//mlYd2gLylCkuRoqWwPztLXFksz7SNsHmSqzRnYO9/njxv
> HS3MTRlsvOiQXiZNXJpfZ6eCigDCfGoVisT8PXnzgoVvlXkVVQkU76J2neTBAkDe
> jadyFhHhfC8mtqA8M+6KShjLDW9Azcky6cZzEyS2DWxzrG0UasQ=
> =PrBj
> -----END PGP SIGNATURE-----


More information about the Spice-devel mailing list