[Spice-devel] [spice-gtk 12/13] usb-redir: use persistent libusb_device under Windows also

Christophe Fergeau cfergeau at redhat.com
Wed Mar 13 17:33:45 UTC 2019


On Wed, Mar 13, 2019 at 10:38:09AM +0200, Yuri Benditovich wrote:
> On Tue, Mar 12, 2019 at 7:31 PM Christophe Fergeau <cfergeau at redhat.com> wrote:
> >
> > On Sun, Mar 10, 2019 at 04:46:11PM +0200, Yuri Benditovich wrote:
> > > Unify SpiceUsbDeviceInfo for Linux and Windows by using
> > > persistent libusb_device.
> >
> > This really needs to be more detailed and explain why this is no longer
> > a valid concern:
> >
> > * On win32 we need to do this the hard and slow way, by asking libusb to
> > * re-enumerate all devices and then finding a matching device.
> > * We cannot cache the libusb_device like we do under Linux since the
> > * driver swap we do under windows invalidates the cached libdev.
> >
> 
> Probably it was written years ago for 'libusb + winusb'; it is just
> incorrect for 'libusb + usbdk'.

Ok, thanks. And usb redirection is not going to work with winusb anyway,
so we should not be concerned about people still using libusb+winusb
instead of libusb+usbdk.
This driver swap is not what can be seen when one inserts an unknown
device in Windows, and then you see it automatically installs a driver?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20190313/a86b6758/attachment.sig>


More information about the Spice-devel mailing list