[Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

Frediano Ziglio fziglio at redhat.com
Mon Mar 18 13:53:33 UTC 2019


> On Mon, Mar 11, 2019 at 12:42:10PM -0400, Frediano Ziglio wrote:
> > > 
> > > Series looks good to me,
> > > 
> > > Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
> > > 
> > 
> > Why not ack? Not good enough? Not tested? Missing something?
> 
> libvirt/qemu use of Reviewed-by/Acked-by confuses me, and to me they are
> more or less equivalent.
> 
> Christophe
> 

As long as we are coherent is fine. But to me looks like some (Jonathon?)
use Reviewed-by to mark as "the patch was fully reviewed but some thinks
need updates".

Frediano


More information about the Spice-devel mailing list