[Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

[Jonathon Jongsma]

On Mon, 2019-03-18 at 09:53 -0400, Frediano Ziglio wrote:
> > On Mon, Mar 11, 2019 at 12:42:10PM -0400, Frediano Ziglio wrote:
> > > > 
> > > > Series looks good to me,
> > > > 
> > > > Reviewed-by: Christophe Fergeau <cfergeau at redhat.com>
> > > > 
> > > 
> > > Why not ack? Not good enough? Not tested? Missing something?
> > 
> > libvirt/qemu use of Reviewed-by/Acked-by confuses me, and to me
> > they are
> > more or less equivalent.
> > 
> > Christophe
> > 
> 
> As long as we are coherent is fine. But to me looks like some
> (Jonathon?)
> use Reviewed-by to mark as "the patch was fully reviewed but some
> thinks
> need updates".
> 
> Frediano

I usually use Reviewed-by to indicate that I looked at it, but am not
necessarily comfortable Acking it yet. But you're right that there's
not really any agreement on what this means. Would be good to be
consistent.

Jonathon