[Spice-devel] About decisions and reviews
Marc-André Lureau
marcandre.lureau at gmail.com
Thu May 14 14:58:18 UTC 2020
Hi
On Thu, May 14, 2020 at 2:32 PM Marc-André Lureau <
marcandre.lureau at gmail.com> wrote:
> Hi
>
> On Mon, May 11, 2020 at 12:16 PM Marc-André Lureau <
> marcandre.lureau at redhat.com> wrote:
>
>> Hi,
>>
>> About "Move code to C++":
>> https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62
>>
>> I would like to know how the decision happened. As long as I have been
>> involved in the Spice project, we had open discussions and did
>> mandatory review for anything non-trivial.
>>
>> This change is substantial, and impacts the work and contribution of
>> others. Where did the discussion happen? Who reviewed the code
>> changes?
>>
>>
> Since no real discussion nor public review took place, I propose to revert
> the change and add a HACKING file to make the rules clear. See:
>
> https://gitlab.freedesktop.org/spice/spice/-/merge_requests/91
>
I propose a spice-space page derived from libvirt "Project governance":
https://gitlab.freedesktop.org/spice/spice-space-pages/-/merge_requests/18
(readable version
https://gitlab.freedesktop.org/spice/spice-space-pages/-/blob/9a1907de182f9f64450a7348e9e6a1423dfa580a/governance.rst
)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20200514/c1ca2f50/attachment.htm>
More information about the Spice-devel
mailing list