[Spice-devel] [PATCH x11spice] Call xf86SetDesiredModes() in DUMMYScreenInit().

[Victor Toso]

Hi,

On Tue, Aug 23, 2022 at 11:39:52AM +0200, Henri Verbeet wrote:
> Otherwise, we may end up with no mode (and thus no refresh rate) set if
> nothing else (like e.g. .xinitrc) sets a mode for us.
>
> Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
> ---
>  spice-video-dummy/src/spicedummy_driver.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/spice-video-dummy/src/spicedummy_driver.c b/spice-video-dummy/src/spicedummy_driver.c
> index 8d8ba48..0ed7f8c 100644
> --- a/spice-video-dummy/src/spicedummy_driver.c
> +++ b/spice-video-dummy/src/spicedummy_driver.c
> @@ -632,6 +632,8 @@ DUMMYScreenInit(SCREEN_INIT_ARGS_DECL)
>
>      if (!xf86CrtcScreenInit(pScreen))
>          return FALSE;
> +    if (!xf86SetDesiredModes(pScrn))
> +        return FALSE;
>
>      xf86DPMSInit(pScreen, xf86DPMSSet, 0);

My knowledge in this area is quite limited but as far as I can
see, this change looks fine.

Cheers,
Victor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20220823/e996e9cb/attachment.sig>