[Spice-devel] [PATCH x11spice] Call xf86SetDesiredModes() in DUMMYScreenInit().

[Frediano Ziglio]

Il giorno mar 23 ago 2022 alle ore 10:57 Henri Verbeet
<hverbeet at codeweavers.com> ha scritto:
>
> Otherwise, we may end up with no mode (and thus no refresh rate) set if
> nothing else (like e.g. .xinitrc) sets a mode for us.
>
> Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
> ---
>  spice-video-dummy/src/spicedummy_driver.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/spice-video-dummy/src/spicedummy_driver.c b/spice-video-dummy/src/spicedummy_driver.c
> index 8d8ba48..0ed7f8c 100644
> --- a/spice-video-dummy/src/spicedummy_driver.c
> +++ b/spice-video-dummy/src/spicedummy_driver.c
> @@ -632,6 +632,8 @@ DUMMYScreenInit(SCREEN_INIT_ARGS_DECL)
>
>      if (!xf86CrtcScreenInit(pScreen))
>          return FALSE;
> +    if (!xf86SetDesiredModes(pScrn))
> +        return FALSE;
>
>      xf86DPMSInit(pScreen, xf86DPMSSet, 0);
>
> --
> 2.20.1
>

Hi Henri,
  not much of an expert.
Looking on the Internet this function is also called in EnterVT
callback. Don't we need something similar?

Frediano