[Swfdec] Patches to make blocky.swf playable

[Nguyen Thai Ngoc Duy]

On 6/24/07, Benjamin Otte <otte at gnome.org> wrote:
> > 0006-Remove-movies-with-the-same-name-when-adding-new-mov.patch
> >
> This is definitely wrong. See attached movie81.as test. It seems the
> movie with the lowest depth is taken if multiple movies have the same
> name.
> Could you give a reason for why this was necessary?

Okay so the fix should go to duplicateMovie(). If my memory serves me
well, cells in blocky.swf (let's take one: t0_0) are duplicated from
movie "tiles" at the beginning of the game. When I complete a level,
t0_0 will be duplicated again. gdb showed me that after t0_0 was
duplicated the second time, level0 had both movies with the same name
"t0_0" and  swfdec_sprite_movie_get_by_name happily gave me the first
t0_0 (while I needed the second one). I'll see if I can mimic the
scenario with a simple actionscript script.

>
> > 0007-We-don-t-handle-replacing-movies-other-than-SwfdecGr.patch
> >
> This touches the "what is copied and what isn't" problem again.
> Someone should take every member of SwfdecMovie (and
> SwfdecSpriteMovie) and write a test if it's copied or not. I'm
> thinking of script properties like color_transform or visible here.
> I'd be interested in the reasons for this patch, too.

Err.. because it would not copy SwfdecSpriteMovie's specific members?
I see you only call klass->replace() for SwfdecGraphicMovie.. For
SwfdecSpriteMovie, only static properties get copied, which is wrong,
I think.

>
> Benjamin
>
>


-- 
Duy