Error when synchronising using 2.0.0 with maemo backends

[Merlijn Wajer]

Hi,

On 22/04/2024 20:12, Merlijn Wajer wrote:

> but I'm curious why it's databases are not showing up - that's probably 
> directly related to the issue I described in my previous email. I'll 
> keep digging.

Well.. it helps to actually enable the backends. I got confused because 
the Maemo backend was installed, but I just realised that even if it is 
not enabled, the backend is still installed. It didn't help that I built 
the package more than a few months ago initially.

However... this wasn't all for nothing, I did find two problems in 
actually compiling the Maemo backend:

1. The dbus headers could not be found, so I added the 
DBUS_CFLAGS/DBUS_LIBS and DBUS_GLIB_CFLAGS/LIBS to maemo.am [1]

2. Commit e88bfa62143bbbf020c234303c941385c7c19014 ("C++: automatically 
determine iterator types") changes the Maemo code in a way that it 
doesn't compile, the fix is trivial [2]

Let me know if I should submit these patches here, or if someone could 
pick up these changes for a new release.

Regards,
Merlijn


[1]

diff --git a/src/backends/maemo/maemo.am b/src/backends/maemo/maemo.am
index 9c31b8de..edbcb2fb 100644
--- a/src/backends/maemo/maemo.am
+++ b/src/backends/maemo/maemo.am
@@ -14,8 +14,8 @@ src_backends_maemo_src = \
    src/backends/maemo/MaemoCalendarSource.cpp

  src_backends_maemo_syncmaemocal_la_SOURCES = $(src_backends_maemo_src)
-src_backends_maemo_syncmaemocal_la_LIBADD = $(MCALB_LIBS) 
$(SYNCEVOLUTION_LIBS)
+src_backends_maemo_syncmaemocal_la_LIBADD = $(MCALB_LIBS) 
$(SYNCEVOLUTION_LIBS) $(DBUS_LIBS) $(DBUS_GLIB_LIBS)
  src_backends_maemo_syncmaemocal_la_LDFLAGS = -module -avoid-version
  src_backends_maemo_syncmaemocal_la_CXXFLAGS = 
$(SYNCEVOLUTION_CXXFLAGS) $(SYNCEVO_WFLAGS)
-src_backends_maemo_syncmaemocal_la_CPPFLAGS = $(SYNCEVOLUTION_CFLAGS) 
-I$(top_srcdir)/test $(BACKEND_CPPFLAGS)
+src_backends_maemo_syncmaemocal_la_CPPFLAGS = $(SYNCEVOLUTION_CFLAGS) 
-I$(top_srcdir)/test $(BACKEND_CPPFLAGS) $(DBUS_CFLAGS) $(DBUS_GLIB_CFLAGS)
  src_backends_maemo_syncmaemocal_la_DEPENDENCIES = 
src/syncevo/libsyncevolution.la


[2]

diff --git a/src/backends/maemo/MaemoCalendarSource.cpp 
b/src/backends/maemo/MaemoCalendarSource.cpp
index 0349c0ee..20cb9e8e 100644
--- a/src/backends/maemo/MaemoCalendarSource.cpp
+++ b/src/backends/maemo/MaemoCalendarSource.cpp
@@ -278,7 +278,7 @@ TrackingSyncSource::InsertItemResult 
MaemoCalendarSource::insertItem(const strin
                  throwError(SE_HERE, string("no events in ical: ") + item);
              }
          }
-        vector< CComponent * auto it = comps.begin();
+        auto it = comps.begin();
          if (comps.size() > 1) {
              for (; it != comps.end(); ++it) {
                  delete (*it);