[systemd-bugs] [Bug 77271] systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jun 5 12:27:54 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=77271

--- Comment #16 from Lennart Poettering <lennart at poettering.net> ---
(In reply to comment #15)
> Created attachment 100447 [details]
> updated patch
> 
> Here is the updated patch.
> Is it ok like that?

Please follow the usual coding style: no redundant {} in single-line if blocks.
Only spaces, no tabs.

The strsep loop looks needlessly complex. Why not just use "while ((cap =
strsep(...)) { .."?

Otherwise looks OK.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20140605/2e040d2a/attachment.html>


More information about the systemd-bugs mailing list