[systemd-bugs] [Bug 77271] systemd-detect-virt and directive ConditionVirtualization wrongly return vm for xen dom0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77271

--- Comment #18 from Andy Melnikov <andy.melnikov at gmail.com> ---
Comment on attachment 100513
  --> https://bugs.freedesktop.org/attachment.cgi?id=100513
new updated patch

Review of attachment 100513:
-----------------------------------------------------------------

::: src/shared/virt.c
@@ +170,2 @@
>          if (r >= 0) {
> +                while (cap = strsep(&domcap, ",")) {

Shouldn't char * cap = NULL be moved here inside if?

@@ +170,3 @@
>          if (r >= 0) {
> +                while (cap = strsep(&domcap, ",")) {
> +                        if (streq(cap, "control_d"))

Can this be moved above into while condition?

while (cap = strsep(&domcap, ",") && !streq(cap, "control_d")) {

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20140606/9c739c51/attachment.html>