[systemd-bugs] [Bug 90385] nspawn: block devices passed to --bind/bind-ro are not accessible inside the container

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90385

--- Comment #3 from Lennart Poettering <lennart at poettering.net> ---
Comment on attachment 115749
  --> https://bugs.freedesktop.org/attachment.cgi?id=115749
patch adapted according to Lennart's implementation suggestions

A couple of fixes:

pleas structly use 8ch space indenting, you appear to indent by 4ch sometimes.

More importantly though, the code for nspawn changed in current git quite a
bind, arg_bind and arg_bind_ro do not exist like this anymore. Please rebase on
current git.

Also, I think this should work the same way for character and block device
nodes. i.e. just checking S_ISBLK() appears to be restrictive.

We currently have two functions is_symlink() and is_dir() in util.[ch]. I think
it would be best to introduce is_device_node() in this style, and move the
stat() check into it, and then look for S_ISBLK() || S_ISCHR()...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-bugs/attachments/20150514/7d731225/attachment.html>