[systemd-commits] configure.ac src/gnome-ask-password-agent.vala TODO

[Kay Sievers]

 TODO                              |    9 +++++++++
 configure.ac                      |    4 ++--
 src/gnome-ask-password-agent.vala |    9 +++++----
 3 files changed, 16 insertions(+), 6 deletions(-)

New commits:
commit afe635e71838c9e62e25a928cbcefc343744dda5
Author: Kay Sievers <kay.sievers at vrfy.org>
Date:   Wed Nov 17 11:58:42 2010 +0100

    update TODO

diff --git a/TODO b/TODO
index 98d37c0..f3788c5 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,12 @@
+* leaving file open on mounted non-root filesystems breaks shutdown
+  systemd is confused if something goes:
+    mounted→unmounting→mounted
+
+* /lib/systemd/systemd-user-sessions stop seems to leave
+  processes behind
+
+* SIGQUIT on shutdown? avahi-daemon[202]: Got SIGQUIT, quitting.
+
 * check if bind mounts work:
     https://bugzilla.novell.com/show_bug.cgi?id=652762
 
diff --git a/configure.ac b/configure.ac
index d29e2d8..d083851 100644
--- a/configure.ac
+++ b/configure.ac
@@ -256,12 +256,12 @@ if test "$have_gtk" = "yes"; then
         AC_SUBST(DBUSGLIB_CFLAGS)
         AC_SUBST(DBUSGLIB_LIBS)
 
-        PKG_CHECK_MODULES(LIBNOTIFY, [ libnotify >= 0.7.0 ])
+        PKG_CHECK_MODULES(LIBNOTIFY, [ libnotify ])
         AC_SUBST(LIBNOTIFY_CFLAGS)
         AC_SUBST(LIBNOTIFY_LIBS)
 fi
 
-AM_PROG_VALAC([0.11])
+AM_PROG_VALAC([0.9])
 AC_SUBST(VAPIDIR)
 AM_CONDITIONAL(HAVE_VALAC, test x"$VALAC" != x)
 
diff --git a/src/gnome-ask-password-agent.vala b/src/gnome-ask-password-agent.vala
index 6cab6f9..1523e2e 100644
--- a/src/gnome-ask-password-agent.vala
+++ b/src/gnome-ask-password-agent.vala
@@ -38,8 +38,8 @@ public class PasswordDialog : Dialog {
                 set_default_response(ResponseType.OK);
                 set_icon_name(icon);
 
-                add_button(Stock.CANCEL, ResponseType.CANCEL);
-                add_button(Stock.OK, ResponseType.OK);
+                add_button(STOCK_CANCEL, ResponseType.CANCEL);
+                add_button(STOCK_OK, ResponseType.OK);
 
                 Container content = (Container) get_content_area();
 
@@ -181,7 +181,8 @@ public class MyStatusIcon : StatusIcon {
 
                 set_visible(true);
 
-                Notification n = new Notification(title, message, icon);
+                Notification n = new Notification(title, message, icon, null);
+                n.attach_to_status_icon(this);
                 n.set_timeout(5000);
                 n.show();
 
@@ -225,7 +226,7 @@ public class MyStatusIcon : StatusIcon {
 
                 OutputStream stream = new UnixOutputStream(to_process, true);
 
-                stream.write(password.data, null);
+                stream.write(password, password.length, null);
         }
 }