[systemd-commits] src/mount.c TODO

Lennart Poettering lennart at kemper.freedesktop.org
Thu Jan 20 16:28:53 PST 2011


 TODO        |    5 -----
 src/mount.c |    1 +
 2 files changed, 1 insertion(+), 5 deletions(-)

New commits:
commit ff2e0f051431de2188561f4700950e229cedcb02
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Jan 21 01:28:30 2011 +0100

    mount: ignore if an fsck is requested for a bind mount, so that we don't wait for the bind 'device' to show up

diff --git a/TODO b/TODO
index 5957b96..bad390c 100644
--- a/TODO
+++ b/TODO
@@ -9,11 +9,6 @@ Bugs:
 * somehow some /etc/fstab supplied mount params are never applied to api fs
   https://bugzilla.redhat.com/show_bug.cgi?id=663108
 
-* bind mounts with 'fsck' fail and block for a minute:
-    /foo /bar none bind 1 1
-  (requesting fsck is wrong, but why do we block for a minute
-   instead of just handling the error)
-
 * isolate multi-user.target doesn't start a getty at tty1 if we run it from graphical.target
 
 * sendmail.service doesn't get rid PID file, fails to kill everything on stop
diff --git a/src/mount.c b/src/mount.c
index aae9d98..d9f3da6 100644
--- a/src/mount.c
+++ b/src/mount.c
@@ -372,6 +372,7 @@ static int mount_add_device_links(Mount *m) {
         }
 
         if (p->passno > 0 &&
+            !mount_is_bind(p) &&
             UNIT(m)->meta.manager->running_as == MANAGER_SYSTEM &&
             !path_equal(m->where, "/")) {
                 char *name;



More information about the systemd-commits mailing list