[systemd-commits] 2 commits - src/socket.c TODO

[Lennart Poettering]

 TODO         |    5 +----
 src/socket.c |    5 +++--
 2 files changed, 4 insertions(+), 6 deletions(-)

New commits:
commit cae18e217208735797232eabb83a93470aefe88f
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Jan 21 02:49:12 2011 +0100

    socket: don't crash if the .service unit for a .socket unit is not found

diff --git a/TODO b/TODO
index 07b42db..2b40b69 100644
--- a/TODO
+++ b/TODO
@@ -8,6 +8,8 @@ Bugs:
 
 * isolate multi-user.target doesn't start a getty at tty1 if we run it from graphical.target
 
+* when plymouth is disabled the console password entry stuff seems to be borked
+
 Features:
 
 * maybe introduce ExecRestartPre=
diff --git a/src/socket.c b/src/socket.c
index 3bb8862..4443dba 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -760,8 +760,9 @@ static int socket_open_fds(Socket *s) {
                                 if ((r = socket_instantiate_service(s)) < 0)
                                         return r;
 
-                                if ((r = label_get_socket_label_from_exe(s->service->exec_command[SERVICE_EXEC_START]->path, &label)) < 0)
-                                        return r;
+                                if (s->service && s->service->exec_command[SERVICE_EXEC_START])
+                                        if ((r = label_get_socket_label_from_exe(s->service->exec_command[SERVICE_EXEC_START]->path, &label)) < 0)
+                                                return r;
 
                                 know_label = true;
                         }

commit 036315352d48c1563ef53b7c0ff58c20e9a2dc8d
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Jan 21 01:54:12 2011 +0100

    update TODO: drop issues that cannot be reproduce or have been fixed otherwise

diff --git a/TODO b/TODO
index bad390c..07b42db 100644
--- a/TODO
+++ b/TODO
@@ -1,8 +1,5 @@
 Bugs:
 
-* sometimes processes seem to remain when we kill a service
-  http://lists.fedoraproject.org/pipermail/devel/2011-January/147559.html
-
 * dep loop when using encrypted swap
   https://bugzilla.redhat.com/show_bug.cgi?id=657234
 
@@ -11,8 +8,6 @@ Bugs:
 
 * isolate multi-user.target doesn't start a getty at tty1 if we run it from graphical.target
 
-* sendmail.service doesn't get rid PID file, fails to kill everything on stop
-
 Features:
 
 * maybe introduce ExecRestartPre=