[systemd-devel] [PATCH] vconsole: properly set terminal UTF-8 mode

[Andrey Borzenkov]

On Fri, Nov 5, 2010 at 7:04 PM, Kay Sievers <kay.sievers at vrfy.org> wrote:
> On Fri, Nov 5, 2010 at 16:58, Andrey Borzenkov <arvidjaar at gmail.com> wrote:
>> On Fri, Nov 5, 2010 at 6:10 PM, Kay Sievers <kay.sievers at vrfy.org> wrote:
>>> On Fri, Nov 5, 2010 at 15:35, Andrey Borzenkov <arvidjaar at gmail.com> wrote:
>>>> We cannot assume terminal is in UTF-8 (actually, unless
>>>> setup by initrd it likely is not). Properly set requested
>>>> mode. This avoids errors similar to
>>>
>>> Why isn't it utf8 by default?
>>>
>>> That should have been changed long ago:
>>>  http://lkml.org/lkml/2007/9/7/37
>>>
>>
>> Actually it was reset to non-UTF8 by systemd-vconsole-setup :p
>>
>> It is rather interesting. I was testing unrelated patch for dracut
>> using dracut tip. It turned out, dracut now installs
>> systemd-vconsole-setup when available. Unfortunately it also also
>> changed parsing of configuration files so no locale config was
>> installed. Which caused vconsole-setup assume we are in non-UNICODE
>> mode and disable it.
>>
>> I still believe we should not make any assumption about console state
>> at the time of systemd startup and ensure it is configured as
>> requested.
>
> I see, then we should fix the vconsole setup if stuff goes wrong here.

That is basically what my patch does.

> We can safely assume that the kernel we rely on is utf8 by default.
>

OK, do you want me to resubmit with fixed description?