[systemd-devel] [PATCH] vconsole: properly set terminal UTF-8 mode
Lennart Poettering
lennart at poettering.net
Wed Nov 10 14:44:58 PST 2010
On Fri, 05.11.10 19:14, Andrey Borzenkov (arvidjaar at gmail.com) wrote:
> >> It is rather interesting. I was testing unrelated patch for dracut
> >> using dracut tip. It turned out, dracut now installs
> >> systemd-vconsole-setup when available. Unfortunately it also also
> >> changed parsing of configuration files so no locale config was
> >> installed. Which caused vconsole-setup assume we are in non-UNICODE
> >> mode and disable it.
> >>
> >> I still believe we should not make any assumption about console state
> >> at the time of systemd startup and ensure it is configured as
> >> requested.
> >
> > I see, then we should fix the vconsole setup if stuff goes wrong here.
>
> That is basically what my patch does.
>
> > We can safely assume that the kernel we rely on is utf8 by default.
> >
>
> OK, do you want me to resubmit with fixed description?
I think it is safe to assume that the kernel enables UTF8 by default. I
see little need to redo what the kernel has been doing anyway already.
Or, in other words: if vconsole-setup for reason didn't work properly in
the initrd we probably should fix that, not then try to work-around this
be enabling UTF8 a second time.
Lennart
--
Lennart Poettering - Red Hat, Inc.
More information about the systemd-devel
mailing list