[systemd-devel] PATCH: do not run fsck on tmpfs mountpoint

[Kay Sievers]

On Wed, Nov 2, 2011 at 15:46, Karel Zak <kzak at redhat.com> wrote:
> On Wed, Nov 02, 2011 at 03:39:37PM +0100, Kay Sievers wrote:

>> >  Unfortunately major(s.st_rdev) is probably useless, try to mount any
>> >  btrfs device :-)
>>
>> Yeah, it was about fsck only, not mount. :)
>
>  Hmm... I'm talking about fsck, try to mount btrfs and check major(st.st_dev)
>  for the mountpoint.

It should be 0, yeah. It's a feature, and I think that it is the right
behavior for btrfs.

I meant, can't fsck skip all devices with a major == 0?

>> >  BTW, in systemd/src/fsck.c I see:
>> >
>> >        /* Virtual root devices don't need an fsck */
>> >        if (major(st.st_dev) == 0)
>> >              return 0;
>> >
>> >  it means that btrfs root will be interpreted as a virtual device :-)
>>
>> Oh, why do we run into the issues with tmpfs then?
>
>  This code is used for system root ("/").

Yeah, makes sense. The question is if we can't do that for everything?

Kay