[PATCH] jobs: When breaking cycles, do not delete dependent jobs.

Colin Guthrie colin at mageia.org
Sun Apr 8 17:41:02 PDT 2012


In some circumstances, a job will be deleted from a cycle which
itself contains as dependancies jobs which are part of the cycle
which is trying to be broken. This is overkill.

Once the cycle is broken, individual jobs will be dropped
if needed but we're in a better position to evaluate which jobs
to be dropped in when we reach that step.

Buglink: https://bugs.mageia.org/show_bug.cgi?id=5262
---
 src/manager.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/manager.c b/src/manager.c
index 74bd740..634b0ff 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -656,7 +656,7 @@ static void transaction_delete_unit(Manager *m, Unit *u) {
          * transaction */
 
         while ((j = hashmap_get(m->transaction_jobs, u)))
-                transaction_delete_job(m, j, true);
+                transaction_delete_job(m, j, false);
 }
 
 static void transaction_clean_dependencies(Manager *m) {
-- 
1.7.10


--------------070207000702030305010501--



More information about the systemd-devel mailing list