[systemd-devel] Upstream service file for NTP daemon chrony

[Lennart Poettering]

On Fri, 22.06.12 11:57, Paul Menzel (paulepanter at users.sourceforge.net) wrote:

> Dear systemd folks,
> 
> 
> Fedora ships systemd service files for chrony [1][2].
> 
> • chrony-wait.service:
> 
>    1 [Unit]
>    2 Description=Wait for chrony to synchronize system clock
>    3 After=chronyd.service
>    4 Requires=chronyd.service
>    5 Before=time-sync.target
>    6 Wants=time-sync.target
>    7 
>    8 [Service]
>    9 Type=oneshot
>   10 # Wait up to ~10 minutes for chronyd to synchronize and the remaining
>   11 # clock correction to be less than 0.1 seconds
>   12 ExecStart=/usr/bin/chronyc waitsync 60 0.1
>   13 RemainAfterExit=yes
>   14 
>   15 [Install]
>   16 WantedBy=multi-user.target
> 
> • chronyd.service:
> 
>    1 [Unit]
>    2 Description=NTP client/server
>    3 After=syslog.target ntpdate.service

Please drop After=syslog.target.

>    4 Conflicts=ntpd.service
>    5 BindTo=systemd-timedated-ntp.target

This last line is not necessary anymore and should be removed.

>    6 
>    7 [Service]
>    8 Type=forking
>    9 EnvironmentFile=-/etc/sysconfig/chronyd

This line is a Fedoraism and should not be adopted upstream.

>   10 ExecStartPre=/usr/libexec/chrony-helper generate-commandkey
>   11 ExecStart=/usr/sbin/chronyd -u chrony $OPTIONS

$OPTIONS should be dropped, just part of the Fedoraism above.

>   12 ExecStartPost=/usr/libexec/chrony-helper add-dhclient-servers
>   13 
>   14 [Install]
>   15 WantedBy=multi-user.target
> 
> Do these look good enough to get upstream? `systemd-arch-units` refused
> a pull request [3].

Otherwise looks OK.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.