[systemd-devel] [PATCH] cryptsetup-generator: allow specifying options in /proc/cmdline

[Thomas Bächler]

Am 19.08.2013 10:34, schrieb Harald Hoyer:
> Hmm, the naming "luks.options" is IMHO poorly chosen. "options" as an option
> name... hmm. Also crypttab can contain more encryption modes, than LUKS.
> 
> If you want to reflect crypttab, why not specify something like:
> 
> [rd.]crypttab=<name>;<device>;<password>;<options>

So, systemd-cryptsetup-generator currently reads luks, luks.crypttab,
luks.uuid and luks.key (+ the rd. variants). Now you are proposing to
add a 'crypttab' option as well. This seems awfully inconsistent to me.

OTOH, allowing to give more options on the command line would open the
door to more encryption schemes than just LUKS (which I don't
particularly care about). I just fear that syntax gets more confusing
when allowing many ways to achieve the same goal.

>        rd.luks.allow-discards=<luks uuid>
>            Allow using of discards (TRIM) requests for LUKS partitions with
>            the given UUID. Any "luks-" of the LUKS UUID is removed before
>            comparing to <luks uuid>. The comparisons also matches, if <luks
>            uuid> is only the beginning of the LUKS UUID, so you don't have to
>            specify the full UUID. This parameter can be specified multiple
>            times.
> 
>        rd.luks.allow-discards
>            Allow using of discards (TRIM) requests on all LUKS partitions.

So 1) you are not actually using systemd-cryptsetup-generator, 2) you
single out this one option and don't support the rest.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130819/5d91f089/attachment.pgp>