[systemd-devel] [PATCH] cryptsetup-generator: allow specifying options in /proc/cmdline

[Harald Hoyer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/19/2013 11:21 AM, Thomas Bächler wrote:
> Am 19.08.2013 10:34, schrieb Harald Hoyer:
>> Hmm, the naming "luks.options" is IMHO poorly chosen. "options" as an
>> option name... hmm. Also crypttab can contain more encryption modes, than
>> LUKS.
>> 
>> If you want to reflect crypttab, why not specify something like:
>> 
>> [rd.]crypttab=<name>;<device>;<password>;<options>
> 
> So, systemd-cryptsetup-generator currently reads luks, luks.crypttab, 
> luks.uuid and luks.key (+ the rd. variants). Now you are proposing to add a
> 'crypttab' option as well. This seems awfully inconsistent to me.

Well, I think before adding more and more rd.luks parameters, we might want to
step back and add one option, which supports all.

An object oriented syntax might be:

rd.luks.<uuid>.name=<name>
rd.luks.<uuid>.options=<options>
rd.luks.<uuid>.password=<password>

This of course would have made parsing with shell functions unpractical.

Now that we already have rd.luks.uuid=<uuid> adding parameters to <uuid>
results in

rd.luks.options=<uuid>=<options>
rd.luks.name=<uuid>=<name>
rd.luks.password=<uuid>=<password>

Both solutions blow up the length of the kernel command line and make it
really unreadable.

This is why I propose to simplify the whole thing and just mirror what we
already support with the crypttab file.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSEewvAAoJEANOs3ABTfJwzLIQAMfKxeRXkVTklsI6EYYpMQ4X
z8F7Mg5Vu79taEZ+e+t71s9U/wNdX6hkCysHQ1qXs8+1IvqxyaFRtdC8HHBSZB0/
CBT6L9v/tH+WOKlEjJesOHPKV1zg2uxRKCHc74bBHdKVJqUrqgB+u42CDsRYq7a0
xgL2Ebvh99a8RoKJEDr+9/Ty+5KgTM0y99z3Wk12JPqAeK+N5z5pnbe6RAW89tG2
f3OjN7Ejf6c+BuJc0S+Eod/2pMV7ccgJJFhKAUQyFYaFfZgG8Wo5sxnUC0SIj508
/MkpVdgrTSsBQt8HxVrlFXm4Zj0M3rA5HsRF77PCPPpJKbU4YAoxkKwMMr6bGEQo
7eeZh3DI/jnpS/QFCDaedDRblWP7rs9e3uso+NDyphq0Th2mg5XiYvhCVsDo5VTX
Ys3o78tcfCUyCSdrNhJ+A3hoKxPI9vn1AmA/AnGyI3WMgXiCFJWtGvR6Us5ClTBh
iYtZvgZexikpqlZXNN3nBjf6J6hxvtNHFpsAweLrigrMBWrJ4cU4nmrWb2A/ei4G
4h/Z60YQmCKXhymmNQGcZMBpzSGfXdDgLqIbtzdFvvRwPBtG2wuvO+cZaCeF0Dye
3oiOYtoLaIGzfPTvUGbV3FSzAb5Cvjy83qSQMmiDeh5pyAIcBqCpmTUKM4cx4ait
xptLc2g2ra1/O59vSyiX
=sjhR
-----END PGP SIGNATURE-----