[systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

[Darren Hart]

On Thu, 2013-08-22 at 00:20 +0200, Kay Sievers wrote:
> On Thu, Aug 22, 2013 at 12:07 AM, Darren Hart <dvhart at linux.intel.com> wrote:
> > On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote:
> >> On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart <dvhart at linux.intel.com> wrote:
> >>
> >> > Hrm, actually no.... that fails finding VERSION ins setup.c. Did
> >> > you ./autogen.sh before building?
> >>
> >> Oh, sorry, it probably just misses:
> >>
> >> +gummiboot_CPPFLAGS = \
> >> +       $(AM_CPPFLAGS) \
> 
> > OK, so you'd prefer to move the -D* args to the CPPFLAGS? I can respin
> > with that with only minimal build testing as that was failing on the
> > host as well.
> 
> Yeah, that's where they technically belong.
> 
> I've just committed the setup.c part, and added a bunch of EFI*
> variable to be able to add stuff at build time. Builds fine here.
> 
> The stuff for gummiboot.efi should be simple to add on top now.

OK, I've rebased and it works... but why did you do the EFI_INCDIR
thing? I've replaced that with --includedir in my series and that is
working for me, including for cross compiling.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel