[systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Wed Aug 21 15:38:29 PDT 2013


On Wed, Aug 21, 2013 at 03:07:24PM -0700, Darren Hart wrote:
> On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote:
> > On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart <dvhart at linux.intel.com> wrote:
> > 
> > > Hrm, actually no.... that fails finding VERSION ins setup.c. Did
> > > you ./autogen.sh before building?
> > 
> > Oh, sorry, it probably just misses:
> > 
> > +gummiboot_CPPFLAGS = \
> > +       $(AM_CPPFLAGS) \
> > 
> > Kay
> 
> OK, so you'd prefer to move the -D* args to the CPPFLAGS? I can respin
> with that with only minimal build testing as that was failing on the
> host as well.
Or better append the define on line 173 in Makefile.am, with all other
defines. We only define per-target cflags when the name is not generic
enough.

Zbyszek


More information about the systemd-devel mailing list